When using the menu tag wrong (eg give a page as 'namespace') the menu ta #935
Conversation
…u tag should fail fast (or ignore the value). This fix prevents some infinite loops in some cases.
…n-invalid-menu-usage
|
Thanks for fixing this so quick! |
|
LGTM. Shouldn't this be backported to classy? Seems to be a useful case for other projects too... And while we're at it, maybe a tag to enforce integer arguments would be useful too? :) That's besides the scope for this pull, but would be interesting in classy I assume. |
|
There already is one for ints in classytags: https://github.com/ojii/django-classy-tags/blob/master/classytags/arguments.py#L89 And I agree, the StringArgument might be useful. |
|
Waiting for classy tags release to pypi, then we will bump the requirements in setup.py and use classy's then version of StrictStringValue instead (or whatever it's called). Then we merge :) |
|
The classytags update will probably happen tonight. This means the b2/rc1 release of the CMS is re-scheduled to Saturday. |
|
alright fixed it in classytags |
When using the menu tag wrong (eg give a page as 'namespace') the menu ta
When using the menu tag wrong (eg give a page as 'namespace') the menu tag should fail fast (or ignore the value). This fix prevents some infinite loops in some cases.